fs: add `Temporal.Instant` support to `Stats` and `BigIntStats` by LiviaMedeiros · Pull Request #60789 · nodejs/node

LiviaMedeiros · 2025-11-20T09:11:04Z

This is a very rough draft, and probably shouldn't land until Temporal implementation is finalized and/or enabled by default.
Opening early to see if there are any objections, suggestions to naming (the *Instant properties are facing userspace and having consistent convention would be nice), or to implementation.

Renegade334 · 2025-11-20T10:18:40Z

~~Since Date.prototype.toInstant() comes along with Temporal, these are fairly trivial to obtain anyway?~~ (Although come to think of it, this would lose nanosecond precision.)

It might be better to have this as a switchable option similar to bigint, rather than adding the overhead of building a load of Temporal objects for every stats call?

LiviaMedeiros · 2025-11-20T10:26:49Z

Since Date.prototype.toInstant() comes along with Temporal, these are fairly trivial to obtain anyway?

Converting from Date would have performance overhead on top of precision loss.

It might be better to have this as a switchable option similar to bigint, rather than adding the overhead of building a load of Temporal objects for every stats call?

These properties are lazy-loaded, so the overhead when not used should be minimal.

codecov · 2026-05-14T22:16:03Z

Codecov Report

❌ Patch coverage is 90.34483% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (a9b0a83) to head (4faf476).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/utils.js	90.20%	14 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #60789    +/-   ##
========================================
  Coverage   90.06%   90.07%            
========================================
  Files         714      714            
  Lines      225629   225876   +247     
  Branches    42702    42742    +40     
========================================
+ Hits       203211   203448   +237     
+ Misses      14232    14205    -27     
- Partials     8186     8223    +37

Files with missing lines	Coverage Δ
lib/internal/errors.js	`97.65% <100.00%> (+<0.01%)`	⬆️
lib/internal/fs/utils.js	`98.43% <90.20%> (-1.25%)`	⬇️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: LiviaMedeiros <livia@cirno.name>

aduh95 · 2026-05-17T14:01:47Z

  Symbol,
  TypedArrayPrototypeAt,
  TypedArrayPrototypeIncludes,
+  globalThis,


Suggested change

globalThis,

globalThis: {

Temporal,

},

Unfortunately this doesn't seem to work since at this point of bootstrapping Temporal is not defined yet.
Same goes for const { Temporal } = globalThis; on top level of the file.

nodejs-github-bot · 2026-05-18T11:27:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73529/

nodejs-github-bot · 2026-05-18T19:08:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73543/

nodejs-github-bot · 2026-05-18T22:18:02Z

Landed in 4ee7567

Signed-off-by: LiviaMedeiros <livia@cirno.name> PR-URL: #60789 Refs: #57891 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

Notable changes: doc: * mark stream.compose stable (Matteo Collina) #62562 fs: * (SEMVER-MINOR) add `Temporal.Instant` support to `Stats` and `BigIntStats` (Livia Medeiros) #60789 http: * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155 PR-URL: #63440

Notable changes: doc: * mark `stream.compose` stable (Matteo Collina) #62562 fs: * (SEMVER-MINOR) add `Temporal.Instant` support to `Stats` and `BigIntStats` (Livia Medeiros) #60789 http: * (SEMVER-MINOR) add `writeInformation` to send arbitrary 1xx status codes (Tim Perry) #63155 PR-URL: #63440

Automated mise tool upgrades from local config. Updated tools: - `action-validator` - `actionlint` - `aube` - `editorconfig-checker` - `ghalint` - `node` - `pinact` - `pipx:gh-action-pulse` - `prek` - `rumdl` - `shellcheck` - `shfmt` - `tombi` - `uv` - `yamlfmt` - `yamllint` - `zizmor` Command: `mise upgrade --bump --local action-validator actionlint aube editorconfig-checker ghalint node pinact pipx:gh-action-pulse prek rumdl shellcheck shfmt tombi uv yamlfmt yamllint zizmor` <details> <summary>Version changelog (node)</summary> | Tool | Requested | Installed | |------|-----------|-----------| | `node` | `24` → `26` | `24.18.1` → `26.5.1` | </details> <details> <summary>Release notes (1 tools)</summary> <details> <summary>node: `24.18.1` → `26.5.1` (nodejs/node)</summary> ### v25.8.2 This is a security release. ### Notable Changes * (CVE-2026-21637) wrap `SNICallback` invocation in `try`/`catch` (Matteo Collina) - High * (CVE-2026-21710) use null prototype for `headersDistinct`/`trailersDistinct` (Matteo Collina) - High * (CVE-2026-21711) include permission check to `pipe_wrap.cc` (RafaelGSS) - Medium * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) - Medium * (CVE-2026-21713) use timing-safe comparison in Web Cryptography HMAC and KMAC (Filip Skokan) - Medium * (CVE-2026-21714) handle `NGHTTP2_ERR_FLOW_CONTROL` error code (RafaelGSS) - Medium * (CVE-2026-21717) test array index hash collision (Joyee Cheung) - Medium * (CVE-2026-21715) add permission check to `realpath.native` (RafaelGSS) - Low * (CVE-2026-21716) include permission check on `lib/fs/promises` (RafaelGSS) - Low ### Commits * \[[`2086b7477b`](nodejs/node@2086b7477b)] - **(CVE-2026-21717)** **build,test**: test array index hash collision (Joyee Cheung) [nodejs-private/node-private#834](https://github.com/nodejs-private/node-private/pull/834) * \[[`0f9332a40a`](nodejs/node@0f9332a40a)] - **(CVE-2026-21713)** **crypto**: use timing-safe comparison in Web Cryptography HMAC and KMAC (Filip Skokan) [nodejs-private/node-private#822](https://github.com/nodejs-private/node-private/pull/822) * \[[`2b6937ddb2`](nodejs/node@2b6937ddb2)] - **deps**: update undici to 7.24.4 (Node.js GitHub Bot) [#62271](nodejs/node#62271) * \[[`bfb8ad5787`](nodejs/node@bfb8ad5787)] - **deps**: update undici to 7.24.3 (Node.js GitHub Bot) [#62233](nodejs/node#62233) * \[[`be6384727f`](nodejs/node@be6384727f)] - **deps**: upgrade npm to 11.11.1 (npm team) [#62216](nodejs/node#62216) * \[[`2feea5bb97`](nodejs/node@2feea5bb97)] - **deps**: V8: override… (truncated) ### v25.9.0 ### Notable Changes #### Test runner module mocking improvements `MockModuleOptions.defaultExport` and `MockModuleOptions.namedExports` have been consolidated into a single option `MockModuleOptions.exports` to align with user expectations and other test runners. A `default` property on `MockModuleOptions.exports` represents the default export, and own enumerable properties are treated as named exports. An automated migration is available to update user code: <https://github.com/nodejs/userland-migrations/tree/main/recipes/mock-module-exports> ```bash npx codemod @nodejs/mock-module-exports ``` Contributed by sangwook in [#61727](nodejs/node#61727). #### Other notable changes * \[[`312476cb84`](nodejs/node@312476cb84)] - **(SEMVER-MINOR)** **async\_hooks**: add using scopes to `AsyncLocalStorage` (Stephen Belanger) [#61674](nodejs/node#61674) * \[[`62d2cd473b`](nodejs/node@62d2cd473b)] - **(SEMVER-MINOR)** **cli**: add `--max-heap-size` option (tannal) [#58708](nodejs/node#58708) * \[[`d0ebf0e44b`](nodejs/node@d0ebf0e44b)] - **(SEMVER-MINOR)** **crypto**: add `TurboSHAKE` and `KangarooTwelve` Web Cryptography algorithms (Filip Skokan) [#62183](nodejs/node#62183) * \[[`f85b9d9fa8`](nodejs/node@f85b9d9fa8)] - **(SEMVER-MINOR)** **repl**: add customizable error handling (Anna Henningsen) [#62188](

LiviaMedeiros added fs Issues and PRs related to file-system APIs and the fs module. experimental Issues and PRs related to experimental features. labels Nov 20, 2025

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 20, 2025

aduh95 reviewed Nov 20, 2025

View reviewed changes

Comment thread lib/internal/fs/utils.js Outdated

aduh95 reviewed Nov 20, 2025

View reviewed changes

Comment thread lib/internal/fs/utils.js Outdated

LiviaMedeiros force-pushed the fs-stats-temporal branch from 22dc64f to d149857 Compare May 14, 2026 20:05

LiviaMedeiros marked this pull request as ready for review May 14, 2026 20:07

LiviaMedeiros commented May 14, 2026

View reviewed changes

Comment thread doc/api/fs.md Outdated

LiviaMedeiros force-pushed the fs-stats-temporal branch from e88849f to 056c074 Compare May 14, 2026 20:10

Renegade334 mentioned this pull request May 14, 2026

lib: add internal Temporal utils #63312

Open

aduh95 reviewed May 15, 2026

View reviewed changes

Comment thread doc/api/fs.md Outdated

aduh95 reviewed May 15, 2026

View reviewed changes

Comment thread lib/internal/fs/utils.js Outdated

LiviaMedeiros force-pushed the fs-stats-temporal branch from b4c96e5 to 65d3bb8 Compare May 15, 2026 08:05

aduh95 approved these changes May 15, 2026

View reviewed changes

Comment thread doc/api/errors.md

LiviaMedeiros mentioned this pull request May 15, 2026

fs: fix enumerability of Date properties on Stats objects #63328

Merged

LiviaMedeiros force-pushed the fs-stats-temporal branch from 64bc610 to c2bd49a Compare May 15, 2026 12:21

jasnell approved these changes May 15, 2026

View reviewed changes

fs: add Temporal.Instant support to Stats and BigIntStats

a46ab03

Signed-off-by: LiviaMedeiros <livia@cirno.name>

LiviaMedeiros force-pushed the fs-stats-temporal branch from 315e806 to a46ab03 Compare May 17, 2026 12:55

squash: simplify getters

112ccf6

aduh95 reviewed May 17, 2026

View reviewed changes

Comment thread lib/internal/fs/utils.js Outdated

aduh95 reviewed May 17, 2026

View reviewed changes

Renegade334 approved these changes May 18, 2026

View reviewed changes

Comment thread doc/api/errors.md Outdated

Comment thread lib/internal/errors.js Outdated

LiviaMedeiros added 2 commits May 18, 2026 21:21

squash: adjust error message

8ad35d8

squash: adjust error message

4faf476

Renegade334 approved these changes May 18, 2026

View reviewed changes

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2026

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 18, 2026

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 18, 2026

nodejs-github-bot merged commit 4ee7567 into nodejs:main May 18, 2026
91 of 92 checks passed

github-actions Bot mentioned this pull request May 19, 2026

2026-05-20, Version 26.2.0 (Current) #63440

Merged

LiviaMedeiros mentioned this pull request May 20, 2026

lib: add internal/primordials_staging module #63464

Open

3 tasks

This was referenced Jul 27, 2026

chore(mise): upgrade local tools jylenhof/mise-update-tool#18

Closed

chore(mise): upgrade local tools jylenhof/mise-update-tool#23

Closed

Navigation Menu

Uh oh!

Uh oh!

fs: add `Temporal.Instant` support to `Stats` and `BigIntStats` - #60789

fs: add `Temporal.Instant` support to `Stats` and `BigIntStats`#60789
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
LiviaMedeiros:fs-stats-temporal

LiviaMedeiros commented Nov 20, 2025

Uh oh!

Renegade334 commented Nov 20, 2025 •

edited

Loading

Uh oh!

LiviaMedeiros commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 May 17, 2026

Uh oh!

LiviaMedeiros May 17, 2026

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

-  globalThis,
+  globalThis: {
+    Temporal,
+  },

Uh oh!

Uh oh!

Conversation

LiviaMedeiros commented Nov 20, 2025

Uh oh!

Renegade334 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LiviaMedeiros commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 May 17, 2026

Choose a reason for hiding this comment

Uh oh!

LiviaMedeiros May 17, 2026

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented May 18, 2026

Uh oh!

Renegade334 commented Nov 20, 2025 •

edited

Loading

codecov Bot commented May 14, 2026 •

edited

Loading