Skip to content

Use gcc included in Windows image for release build - #22

Merged
yawkat merged 4 commits into
yawkat:mainfrom
Marcono1234:windows-gcc
Dec 8, 2025
Merged

Use gcc included in Windows image for release build#22
yawkat merged 4 commits into
yawkat:mainfrom
Marcono1234:windows-gcc

Conversation

@Marcono1234

@Marcono1234 Marcono1234 commented Dec 6, 2025

Copy link
Copy Markdown

See https://github.com/actions/runner-images/blob/win25/20251125.122/images/windows/Windows2025-Readme.md#tools

This simplifies the build config a bit and probably also speeds it up.

Reproducibility-wise I am not sure if it makes a difference (or is actually an improvement) since the previous setup used update: true for the MSYS2 action, so could have broken reproducibility if a new gcc package was released in the meantime.
Using gcc from the GitHub runner image now at least preserves reproducibility until GitHub changes their runner image I guess.

Side note: The previous MSYS2 setup also installed the mingw-w64-x86_64-lz4 package. I think that was redundant since this build is supposed to create the LZ4 binary from source, not use a prebuilt one in any way (?).

@yawkat

yawkat commented Dec 6, 2025

Copy link
Copy Markdown
Owner

lz4 CLI is nice to have. some of the unit tests compare output when it's present. please add it back

@Marcono1234

Marcono1234 commented Dec 6, 2025

Copy link
Copy Markdown
Author

Ah, you mean LZ4FrameIOStreamTest#hasNativeLz4CLI, right? Sorry I wasn't aware of it; and just noticed your commit ea8a193 which added it.

I was wondering now why this was not needed for Ubuntu, but it seems the GitHub runner image has it preinstalled.

Would it be ok if I changed the Windows workflow to just get the LZ4 CLI from https://github.com/lz4/lz4/releases and put it on the PATH? That will probably be faster than the MSYS2 setup.

@yawkat

yawkat commented Dec 7, 2025

Copy link
Copy Markdown
Owner

Sure

@Marcono1234

Copy link
Copy Markdown
Author

Ok, have changed it to download the LZ4 CLI from the LZ4 GitHub release.
For a sample run, see https://github.com/Marcono1234/lz4-java/actions/runs/20034686691/job/57452858090

@yawkat
yawkat merged commit de1e43e into yawkat:main Dec 8, 2025
1 check passed
@Marcono1234
Marcono1234 deleted the windows-gcc branch December 9, 2025 20:53
@yawkat yawkat added the enhancement New feature or request label