Use gcc included in Windows image for release build - #22
Merged
Conversation
Owner
|
lz4 CLI is nice to have. some of the unit tests compare output when it's present. please add it back |
Author
|
Ah, you mean I was wondering now why this was not needed for Ubuntu, but it seems the GitHub runner image has it preinstalled. Would it be ok if I changed the Windows workflow to just get the LZ4 CLI from https://github.com/lz4/lz4/releases and put it on the PATH? That will probably be faster than the MSYS2 setup. |
Owner
|
Sure |
Author
|
Ok, have changed it to download the LZ4 CLI from the LZ4 GitHub release. |
See https://github.com/actions/runner-images/blob/win25/20251125.122/images/windows/Windows2025-Readme.md#tools
This simplifies the build config a bit and probably also speeds it up.
Reproducibility-wise I am not sure if it makes a difference (or is actually an improvement) since the previous setup used
update: truefor the MSYS2 action, so could have broken reproducibility if a new gcc package was released in the meantime.Using
gccfrom the GitHub runner image now at least preserves reproducibility until GitHub changes their runner image I guess.Side note: The previous MSYS2 setup also installed themingw-w64-x86_64-lz4package. I think that was redundant since this build is supposed to create the LZ4 binary from source, not use a prebuilt one in any way (?).