Stop VF hydrator from overwriting in-network verdicts with OON - #55
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop VF hydrator from overwriting in-network verdicts with OON#55Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Primary tweet_id lookup now uses the TimelineHome or Recommendations map that matches candidate.in_network. Ancestor and quote ancillary checks still read Recommendations; retweeted ids stay on TimelineHome. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Pitchfork-and-Torch
marked this pull request as ready for review
August 14, 2026 22:22
Collaborator
|
Thank you for the PR. We’ve integrated a change to address this, and it’s now live. You can see the diff here: 6384ca7#diff-a99a287a275453d2c6164514d6817188f365c774de211e3e2e1fa95d7dc19a6dL108 (This link might not jump you to the right spot in the code, but check Line 108 of vf_candidate_hydrator.rs in this commit.) Closing this PR as completed. |
JoshuaStorm1017
added a commit
to JoshuaStorm1017/x-algorithm
that referenced
this pull request
Sep 2, 2026
…mmendations The xai-org#55 integration reversed the HashMap merge so TimelineHome wins on collision. That restores in-network primaries, but should_drop_ancillary then reads the TimelineHome interstitial/allow for an ancestor or quote that VF already evaluated as a Recommendations Drop. AncillaryVFFilter only removes Action::Drop, so quotes and replies of NSFW / DoNotAmplify / SpamHighRecall in-network parents still make For You. Keep both maps. Primary lookup follows candidate.in_network. Ancestors and quotes stay on TimelineHomeRecommendations. retweeted_tweet_id stays on TimelineHome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VFCandidateHydratorfetches in-network primaries asTimelineHomeand ancestors/quotes asTimelineHomeRecommendations, then merges withall_results.extend(oon_result)so the later key wins.Thunder sets
ancestors = [in_reply_to, conversation_root]on in-network replies. When a parent and reply land in the same batch, the parenttweet_idis in both maps. The selected in-network tweet then gets the Recommendations verdict.TimelineHomeisbase_home_rules()only. Recommendations adds OON-only Drop rules (NSFW_HIGH_PRECISION_DROP,DO_NOT_AMPLIFY_DROP,MALICIOUS_URL_DROP,SPAM_HIGH_RECALL_DROP, NSFW author drops that are Interstitial in-network / Drop OON).VFFilterhard-dropsAction::Drop.This is a successful VF result applied at the wrong safety level. Not fail-open on miss, and not missing labels.
Fix
Keep both maps. Look up
candidate.tweet_idonly from the map that matchescandidate.in_network. Ancestor/quote ancillary checks still use Recommendations.retweeted_tweet_idstays on TimelineHome.Tests