Skip to content
This repository was archived by the owner on Jun 27, 2018. It is now read-only.

fix(reference) support reference import lookup - #19

Merged
teppeis merged 2 commits into
teppeis:typescript-1.5from
basarat:patch-1
Apr 16, 2015
Merged

fix(reference) support reference import lookup#19
teppeis merged 2 commits into
teppeis:typescript-1.5from
basarat:patch-1

Conversation

@basarat

@basarat basarat commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator

refs #15

teppeis added a commit that referenced this pull request Apr 16, 2015
fix(reference) support reference import lookup
@teppeis
teppeis merged commit cbdf39f into teppeis:typescript-1.5 Apr 16, 2015
@teppeis

teppeis commented Apr 16, 2015

Copy link
Copy Markdown
Owner

@basarat LGTM!

@basarat
basarat deleted the patch-1 branch April 16, 2015 03:46
@basarat

basarat commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator Author

@teppeis is typescript-1.5 branch on NPM?

@basarat

basarat commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator Author

PS: thanks for adding me as a collab ❤️

@teppeis

teppeis commented Apr 16, 2015

Copy link
Copy Markdown
Owner

oh, sorry. this pr is for 1.5...

@basarat

basarat commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator Author

oh, sorry. this pr is for 1.5...

Yeah. Reason is that TS 1.4 completely bails and doesn't give any output considering this a syntactic error.

TS 1.5 on the other hand does give an output.

@teppeis

teppeis commented Apr 16, 2015

Copy link
Copy Markdown
Owner

@basarat not yet on npm. WIP in #4.

@basarat

basarat commented Apr 16, 2015

Copy link
Copy Markdown
Collaborator Author

Cool. Fortunately <reference tags are not required anymore now that we tsconfig. So #15 can wait a bit longer.

@teppeis

teppeis commented Apr 16, 2015

Copy link
Copy Markdown
Owner

@basarat thanks for your investigation!
I'll complete #4 and ship it as v2.0.0-alpha after microsoft/TypeScript#2484 is merged.

@midinastasurazz

Copy link
Copy Markdown

Does typescript-simple support tsconfig.json? In particular does it respect files specified? I would like to avoid referencing .d.ts files using /// <reference path="..." /> and instead specify them in files in tsconfig.json. Is that possible?

@teppeis

teppeis commented Apr 25, 2015

Copy link
Copy Markdown
Owner

@midinastasurazz typescript-simple doesn't support for referencing .d.ts. sorry.

@midinastasurazz

Copy link
Copy Markdown

@teppeis Thanks for the info. What about tsconfig.json? Could the files option be used for referencing .d.ts files? It seems to be supported by TypeScript since 1.5. So does typescript-simple essentially disregard tsconfig.json?

@teppeis

teppeis commented Apr 25, 2015

Copy link
Copy Markdown
Owner

@midinastasurazz Loading tsconfig.json is a function of tsc command, not of TypeScript Language.
Even if typescript-simple can load it, doesn't support for multiple files structure including d.ts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants