CI: detect untracked generated files - #1951
Open
mattjohnsonpint wants to merge 1 commit into
Open
Conversation
git diff and git status -uno ignore newly generated untracked files. Check the complete working tree so generation checks cannot pass when code generation creates a new file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newly generated untracked files were being excluded from the safety check performed in CI, due to the git command being used to perform the check.
Changes
Use the exit code from
git status --shortinstead. It check the complete working tree so generation checks cannot pass when code generation creates a new file.Motivation
git diffandgit status -unoignore newly generated untracked files, so the check was incomplete.