Use latest quickstart image for RPC tests - #2669
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The focused workflow change correctly avoids the incompatible nightly XDR format.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates RPC integration tests to use the stable Quickstart image compatible with protocol-27 XDR.
Changes:
- Changes the Quickstart tag from
nightlytolatest. - Retains protocol version 27.
File summaries
| File | Description |
|---|---|
.github/workflows/rpc-tests.yml |
Uses the stable Quickstart image for RPC tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
mootz12
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the explicit
tag: nightlyoverride in the RPC Tests workflow so it uses thelatestquickstart image (the action default established in #2649).Why
The nightly quickstart's captive-core emits newer XDR-JSON — notably
ContractEvent's discriminant astype— that the CLI's pinnedstellar-xdr27.0.0 (viastellar-rpc-client27.0.0) cannot parse, soledger fetchintegration tests fail withmissing field `type_`. Thelatestreleased image matches the CLI's protocol-27 XDR, so the tests pass again.Known limitations
CI no longer exercises upcoming-protocol nightly builds. That coverage can be restored once
stellar-rpc-clientships a release depending onstellar-xdr>= 28.0.0, which reads bothtypeandtype_.