Demo design pass: viz first-load fixes, theme handling, chat chrome cleanup - #114
Demo design pass: viz first-load fixes, theme handling, chat chrome cleanup#114davidkpiano wants to merge 1 commit into
Conversation
- Send serialized machine config (not TS source) to the embed so scenarios render before the first run - Fit the embed camera on init, machine switch, system init, and the editor's loaded signal; the editor never fits on its own - Flip embed theme via @statelyai.setTheme instead of remounting the iframe - Drop the literal-backtick event suffix from action bubbles - Let checkpoint chips use the full rail width before truncating - Move key badges into switcher group labels; drop per-row repetition - Center the empty state, add a one-line premise hint, wrap long starter chips instead of clipping - Remove inert assistant-ui actions (edit, retry, branch picker, export menu); keep Copy - Replace the placeholder header logo with the Stately mark - Bump @statelyai/sdk to ^0.26.1
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe demo updates chat controls and welcome content, replaces header branding, changes scenario visualization input, improves Viz camera fitting and theme updates, and upgrades the ChangesDemo experience
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant DemoShell
participant VizPanel
participant VizPanelStore
participant VizIframe
DemoShell->>VizPanel: pass scenarioVizConfig
VizPanel->>VizPanelStore: initialize and track fitEpoch
VizPanelStore->>VizIframe: initialize embed content
VizIframe-->>VizPanel: `@statelyai.loaded`
VizPanel->>VizIframe: `@statelyai.camera.fit`
VizPanel->>VizIframe: `@statelyai.setTheme`
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
What
A design pass over the demo app, verified live against the running app.
Viz panel
scenarioVizConfig) the embed actually accepts.@statelyai.camera.fitafter init / machine switch / live system init and on the editor's@statelyai.loadedsignal (covers cold loads).@statelyai.setThemeto the live embed.Chat panel
\EVENT`` suffix is gone (the transition log already names the event).Header
Deps
@statelyai/sdk^0.22.1→^0.26.1(itssetThemeprotocol support enables the theme fix).Verification
pnpm --dir demo typecheckand all 64 demo tests pass; root typecheck clean.Not included (upstream candidates)
sky.stately.aiwebsocket warning when a viewer joins a room with no producer (being handled in a separate session against studio/viz).Summary by CodeRabbit
New Features
Improvements