deprecate std::char constants and functions - #153873
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
folkertdev
force-pushed
the
deprecate-char-max
branch
from
March 14, 2026 16:33
3d35ff3 to
00b5d46
Compare
folkertdev
changed the title
std::char::MAXstd::char constants and functions
This comment has been minimized.
This comment has been minimized.
folkertdev
commented
Mar 14, 2026
Comment on lines
-98
to
-106
| /// The maximum number of bytes required to [encode](char::encode_utf8) a `char` to | ||
| /// UTF-8 encoding. | ||
| #[unstable(feature = "char_max_len", issue = "121714")] | ||
| pub const MAX_LEN_UTF8: usize = char::MAX_LEN_UTF8; | ||
|
|
||
| /// The maximum number of two-byte units required to [encode](char::encode_utf16) a `char` | ||
| /// to UTF-16 encoding. | ||
| #[unstable(feature = "char_max_len", issue = "121714")] | ||
| pub const MAX_LEN_UTF16: usize = char::MAX_LEN_UTF16; |
Contributor
Author
There was a problem hiding this comment.
There is currently no core::char::consts module, so currently these constants are just gone. Should they be added as associated consts, or should that core::char::consts module be added?
Contributor
Author
There was a problem hiding this comment.
note to self: the consts being gone completely is the cause of the char_max_len CI failure.
Contributor
There was a problem hiding this comment.
similar to how constants in those modules for numeric types have been deprecated. The
std::charmodule contains:Three stable constants that this PR deprecates. These already link to their associated constant equivalents.
MAXREPLACEMENT_CHARACTERUNICODE_VERSIONtwo unstable constants that this PR removes. The constants are already stablized as associated constants on
char.MAX_LEN_UTF8MAX_LEN_UTF16Four stable functions that this PR deprecates. These already link to their method equivalents.
fn decode_utf16fn from_digitfn from_u32fn from_u32_unchecked⚠discussion at #t-libs > should `std::char::{MIN, MAX}` be deprecated?.
r? libs-api