You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit optimizes implementation of cargo clean -p by reducing the amount of directory walks that take place.
We now batch calls to rm_rf_prefix_list, thus potentially avoiding multiple walks over a single subdirectory. In practice this helps us significantly reduce the runtime for clearing large workspaces (as implemented in #16263); for Zed, cargo clean --workspace went down from 73 seconds to 3 seconds.
We have 216 workspace members.
How to test and review this PR?
We've tested it by hand, running it against regex, ruff and zed codebases.
This PR is still marked as draft, as I don't love the code. I would also understand if y'all were against merging this, given that new build directory layout is in flight.
Co-authored-by: dino dinojoaocosta@gmail.com
What does this PR try to resolve?
This commit optimizes implementation of
cargo clean -pby reducing the amount of directory walks that take place.We now batch calls to
rm_rf_prefix_list, thus potentially avoiding multiple walks over a single subdirectory. In practice this helps us significantly reduce the runtime for clearing large workspaces (as implemented in #16263); for Zed,cargo clean --workspacewent down from 73 seconds to 3 seconds.We have 216 workspace members.
How to test and review this PR?
We've tested it by hand, running it against
regex,ruffandzedcodebases.This PR is still marked as draft, as I don't love the code. I would also understand if y'all were against merging this, given that new build directory layout is in flight.