Add unstructured 2D/3D DFN battery models - #5690
Open
aabills wants to merge 2 commits into
Open
Conversation
This was referenced Jul 31, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ufv-3-plotting #5690 +/- ##
=================================================
Coverage ? 96.84%
=================================================
Files ? 344
Lines ? 34489
Branches ? 0
=================================================
Hits ? 33402
Misses ? 1087
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks
aabills
added a commit
that referenced
this pull request
Aug 5, 2026
- framework errors raise pybamm exceptions (GeometryError, DiscretisationError, DomainError) instead of bare ValueError/KeyError/RuntimeError/TypeError - concise NumPy-style docstrings for the public FiniteVolumeUnstructured operators; from __future__ import annotations in both new modules - meshio and matplotlib load via pybamm.import_optional_dependency so minimal installs get a guided error - dead code removed: _disc_state_vector plumbing (written, never read), n_fpc dead assignment, duplicate cKDTree import; the _hex_gen_params regen branch is documented as the PR #5690 protocol; 3D UnstructuredMeshGenerator honours element_type (docstring previously promised tets while the code always built hexes) - np.unique(..., axis=0) inverse reshaped to 1D (numpy 2.0.0 regression) - comment blocks trimmed to the two-line cap; CHANGELOG bullets carry PR links; Component/Norm/VectorField documented in the API reference Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add BasicDFN2DUnstructured and BasicDFN3DUnstructured on top of the meshing, spatial-method, and plotting stack, plus Max/Min reduction and domain-size helpers needed by those models. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
aabills
force-pushed
the
ufv-3-plotting
branch
from
September 3, 2026 19:31
e70d618 to
c6ca5bf
Compare
aabills
force-pushed
the
ufv-4-models
branch
from
September 3, 2026 19:31
5e1d810 to
240b105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BasicDFN2DUnstructuredandBasicDFN3DUnstructured.Max/Min→Reductionand primary/secondarydomain_sizehelpers used by those models.Stack
MagnitudeAfter this stack merges, #5397 can be closed as superseded. Compare against preserved
unstructured-finite-volume/backup/unstructured-finite-volume-full.Test plan