Warn via FES when bezierOrder() receives a value other than 2 or 3 - #9136
Open
harshiltewari2004 wants to merge 1 commit into
Open
Warn via FES when bezierOrder() receives a value other than 2 or 3#9136harshiltewari2004 wants to merge 1 commit into
harshiltewari2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9079
Changes
bezierOrder()is documented as accepting 2 or 3 but validated nothing, soout-of-range values reached the renderers and failed differently in each:
2D drew nothing, WebGL silently reinterpreted the shape as a quadratic, and
bezierOrder(1)threw a TypeError from inside p5.fn.bezierOrdernow emits a non-blocking FES warning when the order isn't2 or 3. Renderer behaviour is unchanged — this only adds a message.
Per @davepagurek's preference on the issue, the check reads
p5.disableFriendlyErrorsfirst, so a sketch with FES turned off does nofurther work.
order !== undefinedis checked next so the getter form(
bezierOrder()with no argument) doesn't warn.Non-numeric and non-integer values (
'3',2.5,null) also warn, sincethey fail the same comparison.
The order-1 TypeError still occurs after the warning; the warning names
bezierOrderfirst, so the user sees the cause before the crash.PR Checklist
npm run lintpasses