tools: add eslint-plugin-regexp - #62093
Merged
Merged
Conversation
JLHwung
commented
Mar 3, 2026
| 'regexp/no-misleading-capturing-group': 'off', | ||
| 'regexp/no-obscure-range': 'off', | ||
| 'regexp/no-potentially-useless-backreference': 'off', | ||
| 'regexp/no-super-linear-backtracking': 'off', |
Contributor
Author
There was a problem hiding this comment.
This rule can prevent issues like #61904.
Contributor
Author
There was a problem hiding this comment.
Shouldn't this be
errorthen?
Per PR description
To seek consensus on whether we should use this plugin, we have disabled all rules which the current codebase does not meet, so there is no change in the current codebase.
There are around 20 errors from this rule, to limit the scope of this PR, I suggest we discuss whether we should add this eslint plugin. If there is a consensus to add it, then we can always open a new PR to enable rules and fix linting errors.
aduh95
approved these changes
Mar 17, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
I don't see why not. There are conflicts to resolve though
JLHwung
force-pushed
the
add-eslint-plugin-regexp
branch
from
March 18, 2026 03:37
06e5140 to
87076ee
Compare
targos
approved these changes
Mar 18, 2026
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
In this PR we add
eslint-plugin-regexpand its recommended rule set to the current lint rule. To seek consensus on whether we should use this plugin, we have disabled all rules which the current codebase does not meet, so there is no change in the current codebase. I plan to enable some of them in the near future if we agree to add this eslint plugin.