Improve the filename extension detection in MediaAnnotation.prototype._getContentType - #21887
Open
Snuffleupagus wants to merge 1 commit into
Open
Improve the filename extension detection in MediaAnnotation.prototype._getContentType#21887Snuffleupagus wants to merge 1 commit into
MediaAnnotation.prototype._getContentType#21887Snuffleupagus wants to merge 1 commit into
Conversation
…e._getContentType`
Rather than splitting the filename into an Array, and then take its last element, we can directly search for the *last* dot instead.
Doing this also fixes what appears to be a small oversight, since the current code may find a "valid" extension when one doesn't actually exist in the filename. For example, try running the following code in the console:
```js
var filename = "mp4";
filename.split(".").at(-1)?.toLowerCase();
```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21887 +/- ##
=======================================
Coverage 90.28% 90.29%
=======================================
Files 264 264
Lines 67273 67274 +1
=======================================
+ Hits 60737 60742 +5
+ Misses 6536 6532 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than splitting the filename into an Array, and then take its last element, we can directly search for the last dot instead.
Doing this also fixes what appears to be a small oversight, since the current code may find a "valid" extension when one doesn't actually exist in the filename. For example, try running the following code in the console: