Skip to content

Convert the font seacMap and seacs structures into Maps - #21884

Open
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:seacs-Map
Open

Convert the font seacMap and seacs structures into Maps#21884
Snuffleupagus wants to merge 1 commit into
mozilla:masterfrom
Snuffleupagus:seacs-Map

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This changes seacMap from a regular Object into a Map, and the Type1/CFF seacs from (potentially very) sparse Arrays into Maps.

Note: These changes are covered by existing ref-tests such as: issue818.pdf, issue4801, issue4573.pdf, bug1308536.pdf, and glyph_accent.pdf.

This changes `seacMap` from a regular Object into a Map, and the Type1/CFF `seacs` from (potentially very) sparse Arrays into Maps.

*Note:* These changes are covered by existing ref-tests such as: `issue818.pdf`, `issue4801`, `issue4573.pdf`, `bug1308536.pdf`, and `glyph_accent.pdf`.
@codecov-commenter

codecov-commenter commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (716aff9) to head (8dd0057).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21884   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         264      264           
  Lines       67273    67270    -3     
=======================================
+ Hits        60737    60738    +1     
+ Misses       6536     6532    -4     
Flag Coverage Δ
browsertest 66.31% <100.00%> (-0.01%) ⬇️
fonttest 8.93% <0.00%> (+<0.01%) ⬆️
integrationtest 69.44% <92.85%> (+0.01%) ⬆️
unittest 58.48% <100.00%> (+<0.01%) ⬆️
unittestcli 57.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/73940021e818fc8/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/875dba44caadc09/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/73940021e818fc8/output.txt

Total script time: 19.01 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/875dba44caadc09/output.txt

Total script time: 23.58 mins

  • Regression tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants