Skip to content

Replace simple callback functions with arrow functions - #21879

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:callback-arrow-fn
Sep 3, 2026
Merged

Replace simple callback functions with arrow functions#21879
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:callback-arrow-fn

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This improves consistency in the code-base, and it's also slightly shorter which cannot hurt.

@Snuffleupagus Snuffleupagus changed the title Replace simple, one-line, callback functions with arrow functions Replace simple callback functions with arrow functions Sep 3, 2026
This improves consistency in the code-base, and it's also slightly shorter which cannot hurt.
@codecov-commenter

codecov-commenter commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (74515c6) to head (cd8c463).

Files with missing lines Patch % Lines
src/display/content_disposition.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21879   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         264      264           
  Lines       67275    67274    -1     
=======================================
+ Hits        60734    60739    +5     
+ Misses       6541     6535    -6     
Flag Coverage Δ
browsertest 66.31% <0.00%> (+<0.01%) ⬆️
fonttest 8.92% <ø> (ø)
integrationtest 69.44% <0.00%> (+0.01%) ⬆️
unittest 58.48% <33.33%> (+<0.01%) ⬆️
unittestcli 57.02% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/209142488906376/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/da392b07ebf95af/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/209142488906376/output.txt

Total script time: 19.03 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/da392b07ebf95af/output.txt

Total script time: 23.93 mins

  • Regression tests: Passed

@timvandermeij
timvandermeij merged commit 5b20b7b into mozilla:master Sep 3, 2026
21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

This seems more readable indeed; thanks!

@Snuffleupagus
Snuffleupagus deleted the callback-arrow-fn branch September 3, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants