COMPASS-11000: align query and aggregation toolbar icons - #8367
Draft
mongodb-sage-bot[bot] wants to merge 1 commit into
Draft
COMPASS-11000: align query and aggregation toolbar icons#8367mongodb-sage-bot[bot] wants to merge 1 commit into
mongodb-sage-bot[bot] wants to merge 1 commit into
Conversation
## Description Applies the visual icon consistency changes for queries and aggregations: - Docs tab query history button now uses the query (`CurlyBraces`) icon instead of the recent (`Clock`) icon. - Aggregation saved pipelines button now uses the query (`CurlyBraces`) icon instead of the folder (`Folder`) icon. - Removed the star (`Favorite`) icon from the Save button in the bulk Update modal. - Removed the save (`Save`) icon from the aggregation Save / Save as dropdown button. Unused `Icon` imports left behind by the two removals were dropped, and tests were added to cover each changed button. ### Checklist - [x] New tests and/or benchmarks are included - [ ] Documentation is changed or added - [ ] If this change updates the UI, screenshots/videos are added and a design review is requested - [ ] If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact - [ ] I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement) ## Motivation and Context Part of the parent effort to make icons consistent across the queries and aggregations experiences (COMPASS-10999). The query history and saved pipelines entry points should share the same query icon, and the Save actions should not carry mismatched star/save glyphs. - [ ] Bugfix - [ ] New feature - [ ] Dependency update - [x] Misc ## Types of changes - [ ] _Backport Needed_ - [x] Patch (non-breaking change which fixes an issue) - [ ] Minor (non-breaking change which adds functionality) - [ ] Major (fix or feature that would cause existing functionality to change)
Author
|
Sage Bot can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applies the visual icon consistency changes for queries and aggregations:
CurlyBraces) iconinstead of the recent (
Clock) icon.CurlyBraces)icon instead of the folder (
Folder) icon.Favorite) icon from the Save button in the bulkUpdate modal.
Save) icon from the aggregation Save / Save asdropdown button.
Unused
Iconimports left behind by the two removals were dropped, andtests were added to cover each changed button.
Checklist
Motivation and Context
Part of the parent effort to make icons consistent across the queries and
aggregations experiences (COMPASS-10999). The query history and saved
pipelines entry points should share the same query icon, and the Save
actions should not carry mismatched star/save glyphs.
Types of changes
Important
MongoDB Contribution Guidelines
This pull request was generated by sage-bot on behalf of misba.abbas@mongodb.com (ticket assignee). The assignee must self-review the changes before requesting review from another engineer.
The assignee is not allowed to merge their own PR without approval from another engineer.