Skip to content

Reduce instance size of Identifier - #52175

Closed
Ron Buckton (rbuckton) wants to merge 1 commit into
mainfrom
id-cleanup-2
Closed

Reduce instance size of Identifier#52175
Ron Buckton (rbuckton) wants to merge 1 commit into
mainfrom
id-cleanup-2

Conversation

@rbuckton

@rbuckton Ron Buckton (rbuckton) commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Testing a much smaller change than #52170.

@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 9, 2023
@rbuckton

Ron Buckton (rbuckton) commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) perf test

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at bb5edf1. You can monitor the build here.

Update: The results are in!

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Ron Buckton (@rbuckton)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52175
Metric main 52175 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,650k (± 0.01%) 382,421k (± 0.01%) +9,771k (+ 2.62%) 382,353k 382,505k
Parse Time 3.94s (± 0.68%) 3.99s (± 0.86%) +0.05s (+ 1.27%) 3.94s 4.04s
Bind Time 1.20s (± 0.73%) 1.21s (± 0.85%) +0.01s (+ 1.10%) 1.20s 1.23s
Check Time 8.60s (± 0.76%) 8.62s (± 0.34%) +0.02s (+ 0.18%) 8.59s 8.66s
Emit Time 7.53s (± 0.94%) 7.54s (± 0.36%) +0.00s (+ 0.06%) 7.48s 7.56s
Total Time 21.27s (± 0.56%) 21.35s (± 0.27%) +0.08s (+ 0.36%) 21.27s 21.43s
Compiler-Unions - node (v18.10.0, x64)
Memory used 198,370k (± 0.03%) 205,458k (± 1.43%) +7,089k (+ 3.57%) 203,499k 209,363k
Parse Time 1.64s (± 1.25%) 1.68s (± 1.04%) +0.04s (+ 2.29%) 1.65s 1.69s
Bind Time 0.79s (± 0.69%) 0.79s (± 0.64%) +0.00s (+ 0.59%) 0.79s 0.80s
Check Time 9.41s (± 0.88%) 9.59s (± 0.37%) +0.18s (+ 1.93%) 9.54s 9.64s
Emit Time 2.78s (± 1.57%) 2.78s (± 1.22%) -0.00s (- 0.08%) 2.73s 2.83s
Total Time 14.62s (± 0.47%) 14.84s (± 0.46%) +0.22s (+ 1.51%) 14.75s 14.92s
Monaco - node (v18.10.0, x64)
Memory used 354,100k (± 0.01%) 362,933k (± 0.01%) +8,833k (+ 2.49%) 362,879k 362,986k
Parse Time 2.93s (± 0.81%) 3.00s (± 0.97%) +0.07s (+ 2.40%) 2.96s 3.04s
Bind Time 1.04s (± 1.11%) 1.05s (± 1.16%) +0.02s (+ 1.51%) 1.04s 1.07s
Check Time 7.21s (± 0.39%) 7.21s (± 0.24%) -0.00s (- 0.05%) 7.19s 7.24s
Emit Time 4.27s (± 0.60%) 4.29s (± 0.77%) +0.02s (+ 0.53%) 4.24s 4.34s
Total Time 15.44s (± 0.32%) 15.55s (± 0.33%) +0.11s (+ 0.69%) 15.49s 15.63s
TFS - node (v18.10.0, x64)
Memory used 310,027k (± 0.00%) 318,901k (± 0.01%) +8,874k (+ 2.86%) 318,879k 318,932k
Parse Time 2.27s (± 0.48%) 2.46s (± 1.67%) +0.20s (+ 8.68%) 2.41s 2.52s
Bind Time 1.16s (± 1.28%) 0.99s (± 1.37%) 🟩-0.17s (-14.63%) 0.98s 1.02s
Check Time 6.82s (± 0.55%) 6.81s (± 0.62%) -0.01s (- 0.14%) 6.74s 6.87s
Emit Time 3.93s (± 0.91%) 3.96s (± 0.87%) +0.03s (+ 0.69%) 3.91s 4.00s
Total Time 14.19s (± 0.52%) 14.22s (± 0.54%) +0.04s (+ 0.28%) 14.12s 14.34s