refactor: flatten skills/ and adopt Agent Plugins 1.0 - #807
Draft
mattpocock wants to merge 1 commit into
Draft
Conversation
The Agent Plugins standard reads only the immediate children of skills/ and cannot be pointed elsewhere, so a bucketed tree is invisible to every conformant client. Rather than generate a flat copy of the repo into a package directory — a builder, a validator, an allowlist, a drift CI job, and every skill committed twice — remove the buckets. - skills/ is flat and holds exactly the promoted 25 - in-progress/ -> drafts/, misc/ -> extras/, deprecated/ deleted - new root plugin.json (Agent Plugins 1.0) - .claude-plugin/plugin.json loses its 25-entry skills array - docs/ keeps its category folders; it is now the only place a skill's category lives Reasoning in .agents/adr/0003. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a16a267 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
you could actually have it as a marketplace and define the plugins in each one of the directories you have in the main branch. I tested it in both Claude and Codex and it works (Codex supports Claude marketplaces). Like this You need
|
|
hii |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone proposed packaging this repo as an Agent Plugins 1.0 plugin: a generated flat package under
plugins/mattpocock-skills/, built by two TypeScript scripts, guarded by a validator, an allowlist and a CI job that fails on any rebuild diff — with all 25 skills committed twice.That whole apparatus exists to work around one thing: the standard reads only the immediate children of
skills/, andplugin.jsoncannot point elsewhere. Our skills sit one level too deep.So this PR removes the buckets instead. Conformant by layout, not by tooling. Full reasoning, including what we deliberately didn't do, is in ADR 0003.
What changed
skills/is flat and holds exactly the promoted 25. Which folder a skill lives in is now the only thing that decides whether it ships.in-progress/→drafts/,misc/→extras/, both outsideskills/.deprecated/deleted — it was empty.plugin.json: the Agent Plugins 1.0 manifest. Read by Codex, Cursor and Copilot..claude-plugin/plugin.jsonkeeps serving Claude Code and loses its 25-entryskillsarray — one promotion mechanism, not two.sync-plugin-version.mjsnow syncs both manifests, andcheck-plugin-versionis wired into the release workflow.link-skills.shlinksskills/,drafts/andextras/, preserving today's dev behaviour.Free win
npx skills@latest add mattpocock/skillshas been offering all 35 skills — every draft and extra included. It walksskills/to depth 3 regardless of any manifest. Moving them out narrows the offer to the promoted 25.What this does NOT do
.codex-plugin/or.cursor-plugin/manifest. Cursor documents dual support outright; the Codex source reads rootplugin.jsonfirst. The proposal was more conservative than either client..claude-plugin/marketplace.jsonand Codex treats it as legacy-compatible, so the one we have may already serve all three. Add others only where a real install fails.mp.mattpocock-skillsis live in Claude Code's official marketplace with auto-update. Renaming breaks every existing install for a shorter slash command.docs/. It would force 27 manualgithubSourcerepoints on aihero.dev, one CLI call each, for zero technical gain.Verified
name; all 25agents/openai.yamlpreserved; nestedscripts/andtemplate.shassets intact.skills/.check-plugin-versionpasses.claude plugin validate . --strictpasses.CLAUDE_CONFIG_DIRfrom the local marketplace — installs and reports enabled.Not verified — do this before release
skillsarray means relying on auto-discovery. The isolated test home isn't authenticated, so the count is unproven. Install from a clean profile and count.disable-model-invocation, which is not in the Agent Skills standard. We rely on non-Claude clients ignoring an unknown frontmatter key. Confirm/grill-medoesn't self-fire..agents/install-block.mdstill says "the plugin is Claude Code only". Deliberately left alone — update it once a Codex/Cursor install is actually tested.