Skip to content

Cpp suggestions - #741

Open
asarhaddon wants to merge 19 commits into
kanaka:masterfrom
asarhaddon:cpp-suggestions
Open

Cpp suggestions#741
asarhaddon wants to merge 19 commits into
kanaka:masterfrom
asarhaddon:cpp-suggestions

Conversation

@asarhaddon

@asarhaddon asarhaddon commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Hello. Here are some suggestions for the c++ implementation.

@asarhaddon
c++: improve Makefile
4179616 
Compute system name with only one subprocess.
Use predefined Make rules and variables when possible.
Keep *FLAGS from the environment or command line.
Allow the Make command line to override for example the -O option.
Split LDLIBS from LDFLAGS and CPPFLAGS from CXXFLAGS.
Pass compiler flags to the linker (this is necessary for -Og, safe otherwise).
@asarhaddon
c++: reduce the diff between steps 345
b801441 
Best viewed with `git diff -b`, only the indentation changes.
This will help when applying the same patch to each step.
@asarhaddon
c++: replace include guards with pragma once