Skip to content

馃И add engines test - #136

Merged
ctcpip merged 2 commits into
masterfrom
engines!
Jul 21, 2025
Merged

馃И add engines test#136
ctcpip merged 2 commits into
masterfrom
engines!

Conversation

@ctcpip

@ctcpip ctcpip commented Mar 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

failing engines test before engines change with 0.6: https://github.com/jshttp/mime-types/actions/runs/14111833661/job/39532276468?pr=136

passing engines test after engines change to 18: https://github.com/jshttp/mime-types/actions/runs/14111854628/job/39532350886?pr=136

resolves #135

@bjohansebas

bjohansebas commented Mar 27, 2025

Copy link
Copy Markdown
Member

I don't fully understand your change. How does that fix the original problem? Are we going to release a new major version?

@ctcpip

ctcpip commented Mar 27, 2025

Copy link
Copy Markdown
Member Author

@bjohansebas as mentioned in the issue, we are not going to release a new major just for an engines change. what is your understanding of the "original problem"?