Handle Actions Cancel Workflow Run returning a 202 - #855
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the GitHub Actions cancel workflow run command incorrectly treats a 202 Accepted response as an error. The GitHub API returns a 202 status code on successful cancellation, but the go-github library wraps this as an AcceptedError which was being handled as a failure.
- Handle
github.AcceptedErroras a success case instead of an error - Add test coverage for both successful cancellation (202) and conflict scenarios (409)
- Update test assertion to use
Containsfor more flexible error message matching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/actions.go | Add error type checking to handle AcceptedError as success |
| pkg/github/actions_test.go | Add comprehensive test cases and improve mock response handling |
almaleksia
previously approved these changes
Aug 11, 2025
JoannaaKL
approved these changes
Aug 12, 2025
Actions Cancel Workflow Run returns a 202 on success, but this is returned as an error in
google/go-github. We need to check if the error is a*github.AcceptedError, and only if not respond that this failed.