Remove FMT_API from ostream class to members - #4584
Merged
Merged
Conversation
Contributor
|
It was not just formatting but a build breakage due to a botched merge, please rebase past a2289b8. |
Putting FMT_API on the class definition propagates it to the base class detail::buffer<char>'s members. However, MSVC not emit definitions for inline members unless it sees the symbols as FMT_API when compiling. This fix removes the FMT_API declaration from the class itself and marks individual non-inline members as FMT_API to address the issue. Fixes fmtlib#4576
FatihBAKIR
force-pushed
the
os-fmt-api-fix
branch
from
October 19, 2025 17:54
396dddb to
959c50d
Compare
Contributor
|
Thank you! |
Putting FMT_API on the class definition propagates it to the base class detail::buffer's members. However, MSVC not emit definitions for inline members unless it sees the symbols as FMT_API when compiling.
This fix removes the FMT_API declaration from the class itself and marks individual non-inline members as FMT_API to address the issue.
Fixes #4576