Simplify a copying the fill from basic_specs - #4290
Merged
Merged
Conversation
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Contributor
Author
|
@ja11sop , test this PR, please. |
|
I just ran against this PR and all looks good |
Contributor
Author
|
@vitaut please review this PR. |
Contributor
|
I wonder why the issue reported in #4289 hasn't been caught by existing tests? It might be worth adding a regression test. |
Contributor
Author
|
I'm guessing that a previous version of the code might have corrupted memory somewhere earlier. I don't see the root of case for this error, but I think move the The code from PR is free of any possibility of memory corruption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify code.
Fix for #4289