Fix conversion warning on chrono.h - #4170
Merged
Merged
Conversation
warning: conversion from 'time_t' {aka 'long long int'} to 'long int' may change value [-Wconversion]
vitaut
requested changes
Sep 20, 2024
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. I think the correct fix is to change write_utc_offset so that it takes long long.
…_cast as requested..
Contributor
Author
|
Ok, I did the changes as requested and removed the cast from |
vitaut
approved these changes
Sep 20, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting from 'long long int' into 'long int' to remove the warning from -Wconversion as the method write_utc_offset accepts a long, and the offset should be in the range of a long variable.