Add support formatting std::expected<void, E> - #4148
Merged
Conversation
phprus
commented
Sep 4, 2024
| is_formattable<E, Char>::value>> { | ||
| struct formatter< | ||
| std::expected<T, E>, Char, | ||
| std::enable_if_t<detail::is_expected_formattable<T, Char>::value && |
Contributor
Author
There was a problem hiding this comment.
We can not use:
std::is_void<T>::value || is_formattable<T, Char>::valuesince is_formattable<void, Char>::value give compile-time error.
vitaut
requested changes
Sep 4, 2024
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
is_formattable now works with void so let's remove is_expected_formattable.
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
phprus
marked this pull request as ready for review
September 4, 2024 15:57
vitaut
approved these changes
Sep 4, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #4145.
Requires #4151. With #4151 we can remove temporary CI commit.