Skip to content

docker auth: improve missing user/pwd - #706

Merged
crazy-max merged 1 commit into
docker:masterfrom
Frankkkkk:patch-1
May 27, 2024
Merged

docker auth: improve missing user/pwd#706
crazy-max merged 1 commit into
docker:masterfrom
Frankkkkk:patch-1

Conversation

@Frankkkkk

Copy link
Copy Markdown
Contributor

Specify the "missing username and password" error message. This makes debugging the action easier when for example mistyping the username or the password.

Thanks and cheers!

@crazy-max

Copy link
Copy Markdown
Member

Thanks for this PR but I think the error message to users should remain generic. You can still check what value is empty in the login step (expand Run docker/login-action@v3):

image

@Frankkkkk

Copy link
Copy Markdown
Contributor Author

Hi @crazy-max , thanks for your message.
Any reason why you want the error message to be generic? I genuinely can't see why?

These actions are also used outside Github (for example on Gitea or Forgejo. Basically on any act runner). On those, the details are not shown:
image
Thus why it adds more info
Thanks

@crazy-max crazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.