Skip to content

fix: check reqs exist - #1835

Merged
joseph-sentry merged 3 commits into
mainfrom
joseph/shell
Jun 25, 2025
Merged

fix: check reqs exist#1835
joseph-sentry merged 3 commits into
mainfrom
joseph/shell

Conversation

@joseph-sentry

@joseph-sentry joseph-sentry commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

We are requiring users to have the requirements for the action installed ahead of time, and we want to be in control of the error messaging.

@joseph-sentry
joseph-sentry requested review from a team and spalmurray June 2, 2025 22:25
# The branches below must be a subset of the branches above
branches: [ main ]
branches: [main]
schedule:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL how to schedule action runs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, these are... fluffy. don't rely on crons in GHA for precise timing

Comment thread .github/workflows/main.yml Outdated
verbose: true
token: ${{ secrets.CODECOV_TOKEN }}

run-alpine:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge. 🥔

Comment thread action.yml Outdated
runs:
using: "composite"
steps:
- name: Detect shell

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary? Can't we just use sh for everything?

Comment thread action.yml Outdated
fi
- name: Action version
shell: bash
shell: ${{ env.CC_SHELL }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W that all this stuff just works in the less featured shells

@spalmurray spalmurray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1q