[CLOSED] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache

[core-ai-bot]

Issue by tvoliter
Friday Aug 10, 2012 at 00:04 GMT
Originally opened as adobe/brackets#1358

---

• includes jdiel's "language switching" pull request Added Language Switching adobe/brackets#1285 which includes DE translations, a menu and UI for switching languages, and string lookup support through i18n.js
• added new module htmlContentLoad.js that dynamically loads main-view.html, localizes it using i18n.js + mustache.js, and injects it into the body of index.html
• body of index.html moved to main-view.html
• modified SideBarView.js to depend on htmlContentLoad since this module modifies HTML on load.

3rd Party Code Notice: Mustache.js uses an MIT license: https://github.com/janl/mustache.js/blob/master/LICENSE. I will need to complete the Brackets third party check list before this pull request can be merged.

---

tvoliter included the following code: https://github.com/adobe/brackets/pull/1358/commits

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 10, 2012 at 16:23 GMT

---

Initial review complete.

[core-ai-bot]

Comment by jasonsanjose
Monday Aug 13, 2012 at 18:22 GMT

---

Also, we need to verify the 3rd party code checklist.

[core-ai-bot]

Comment by jasonsanjose
Monday Aug 13, 2012 at 22:34 GMT

---

Need to merge with master

[core-ai-bot]

Comment by jasonsanjose
Monday Aug 13, 2012 at 22:58 GMT

---

The working set wasn't working properly when I did some testing. See my comment in SidebarView.js.

[core-ai-bot]

Comment by tvoliter
Tuesday Aug 14, 2012 at 19:51 GMT

---

Working on this now…

From: Jason San Jose [mailto:notifications@github.com]
Sent: Monday, August 13, 2012 3:35 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache (#1358)

Need to merge with master

—
Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/pull/1358#issuecomment-7710502.

[core-ai-bot]

Comment by tvoliter
Tuesday Aug 14, 2012 at 20:41 GMT

---

Code code review fixes pushed and I merged with master