ZipArchiveOutputStream.addRawArchiveEntry() should check is2PhaseSource

[yujincheng08]

This allows users to add manually compressed raw data to the zip file under an unsupported compression method (e.g., XZ) or encrypt method.

Sample usage:

val data = "hello world".toByteArray()
ZipArchiveOutputStream(File("test.zip")).use { zip ->
    val entry = ZipArchiveEntry("test")
    entry.method = ZipMethod.XZ.code
    entry.crc = CRC32().apply { update(data) }.value
    ByteArrayOutputStream().use { os ->
        XZCompressorOutputStream(os).use {
            it.write(data)
        }
        entry.size = data.size.toLong()
        entry.compressedSize = os.size().toLong()
        zip.addRawArchiveEntry(entry, ByteArrayInputStream(os.toByteArray()))
    }
}

Previously these codes would throw an exception about the unsupported compression method.

[garydgregory]

Hello @yujincheng08

Thank you for your PR.

This PR is missing tests.

Where is this feature documented?

[yujincheng08]

Hi, @garydgregory,

Test added.

And this feature is already documented:

commons-compress/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveOutputStream.java

Lines 483 to 496 in 287e94b

	/**
	* Adds an archive entry with a raw input stream.
	* <p>
	* If crc, size and compressed size are supplied on the entry, these values will be used as-is. Zip64 status is re-established based on the settings in this
	* stream, and the supplied value is ignored.
	* </p>
	* <p>
	* The entry is put and closed immediately.
	* </p>
	*
	* @param entry The archive entry to add
	* @param rawStream The raw input stream of a different entry. May be compressed/encrypted.
	* @throws IOException If copying fails
	*/

According to the document, the rawStream may be compressed/encrypted, and if crc, size and compressed size are supplied on the entry, these values will be used as-is. So there's no reason to check if the compression method or encryption method is supported or not when crc, size and compressed size are supplied (we don't need to calculate these values and we don't need to compress or encrypt the data).

[garydgregory]

@yujincheng08
Please do not use star imports, this causes the build checks to fail.
Run mvn by itself before you push to catch all build errors.
TY!

[yujincheng08]

@garydgregory Thank you. Fixed.

[garydgregory]

@yujincheng08

Thank you for your work. Merged!