fix: allow creating new files in nested non-existent directories - #1741
Open
Juwan-Hwang wants to merge 1 commit into
Open
fix: allow creating new files in nested non-existent directories#1741Juwan-Hwang wants to merge 1 commit into
Juwan-Hwang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When validating paths for new files that have not yet been created,
validatePathWithinRepofell back to callingrealpath(parentDir)on the immediate parent directory.If a new file is being created inside nested directories that do not yet exist (for example
src/components/button/index.tsxwhere neithercomponents/norbutton/has been created yet),realpath(parentDir)threwENOENT, which was caught and caused the function to incorrectly reject the valid path withPath '...' resolves outside the repository root.Solution
Update
validatePathWithinRepoto walk up the directory tree to find the closest existing ancestor directory:resolvedRoot.initialPathfor the non-existent target path once the ancestor is validated.Testing
src/components/button/index.tsx).deeply/nested/non/existent/dir/file.txt).../outside/...) and escaping symlinks continue to be correctly rejected for non-existent nested paths.27 pass, 0 fail).bun run format:check,bun run typecheck).