Fix hashtable insertion race. (Free-Threaded) - #1327
Open
Vizonex wants to merge 8 commits into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Member
Author
|
Would be nice if we made a label for free-threaded pull requests but I don't know if that will be necessary yet. |
Member
Author
|
3.13t plans to be removed by #1326 so I'm not so concerned if 3.13t fails. |
3 tasks
Member
|
Labels are cheap, I've added one. |
webknjaz
reviewed
Apr 29, 2026
webknjaz
reviewed
Apr 29, 2026
| import sysconfig | ||
| import textwrap | ||
|
|
||
| FREETHREADED = bool(sysconfig.get_config_var("Py_GIL_DISABLED")) |
Member
There was a problem hiding this comment.
I'm not convinced we should gate on this here.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 28 29 +1
Lines 3627 3636 +9
Branches 265 266 +1
=======================================
+ Hits 3622 3631 +9
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change comes related to _md_add_with_hash_steal_refs Which mentions a possible hashtable insertion race in free-threaded mode.
Are there changes in behavior for the user?
this should not affect the pure python version of multidict only the C version.
Related issue number
Checklist