Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Improve console output of LiveDevelopment errors (#1200) - #1232

Merged
gruehle merged 1 commit into
adobe:masterfrom
DennisKehrig:master
Jul 11, 2012
Merged

Improve console output of LiveDevelopment errors (#1200)#1232
gruehle merged 1 commit into
adobe:masterfrom
DennisKehrig:master

Conversation

@DennisKehrig

Copy link
Copy Markdown
Contributor

Before:
Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed

After:
Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed
Parameter 'lineNumber' has wrong type. It must be 'Number'.
Parameter 'url' has wrong type. It must be 'String'.
[expandable error object]

Before:
	Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed

After:
	Some arguments of method 'Debugger.setBreakpointByUrl' can't be processed
	Parameter 'lineNumber' has wrong type. It must be 'Number'.
	Parameter 'url' has wrong type. It must be 'String'.
	[expandable error object]
@DennisKehrig

Copy link
Copy Markdown
Contributor Author

See #1200

@gruehle

gruehle commented Jul 11, 2012

Copy link
Copy Markdown
Member

Thanks! Merging.

gruehle added a commit that referenced this pull request Jul 11, 2012
Improve console output of LiveDevelopment errors (#1200)
@gruehle
gruehle merged commit d892cac into adobe:master Jul 11, 2012
@peterflynn

Copy link
Copy Markdown
Member

Oops, it looks like this violates #1096 though. @DennisKehrig, are you planning any more work in this file? If so, we could wait and roll up the fix into a later pull request, instead of making a whole commit just for this one-line change...

@DennisKehrig

Copy link
Copy Markdown
Contributor Author

@peterflynn No, not right now... I just went ahead and added another pull request.

I'm surprised this isn't mentioned in the Coding Conventions. Is it mentioned somewhere else?
I noticed some discussion about $.each vs. Array.forEach, too - ideally I'd like to find information on what to use for iterating objects vs. arrays in a central place.

@DennisKehrig

Copy link
Copy Markdown
Contributor Author

Thanks, guys!