Skip to content

Add HashFiles to the toolkit - #830

Merged
thboop merged 10 commits into
mainfrom
thboop/HashFiles
Jun 7, 2021
Merged

Add HashFiles to the toolkit#830
thboop merged 10 commits into
mainfrom
thboop/HashFiles

Conversation

@thboop

@thboop thboop commented Jun 4, 2021

Copy link
Copy Markdown
Collaborator

Resolves #472

thboop
thboop commented Jun 4, 2021
View reviewed changes
Comment thread packages/glob/src/internal-hash-files.ts Outdated
core.debug(`Found ${count} files to hash.`)
return result.digest('hex')
} else {
core.error(`No matches found for glob`)

@thboop thboop Jun 4, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should we do when no files are found?

@luketomlinson luketomlinson Jun 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this feels more like a warning than an error

@urica12 urica12 Oct 17, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@urica12 urica12 Oct 17, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

thboop
thboop commented Jun 4, 2021
View reviewed changes
Comment thread packages/glob/__tests__/hash-files.test.ts
thboop
thboop commented Jun 4, 2021
View reviewed changes
Comment thread packages/glob/__tests__/hash-files.test.ts
@thboop
thboop marked this pull request as ready for review June 7, 2021 15:11
@thboop
thboop requested a review from a team as a code owner June 7, 2021 15:11
@thboop
thboop requested a review from luketomlinson June 7, 2021 15:11
luketomlinson
luketomlinson approved these changes Jun 7, 2021
View reviewed changes

@luketomlinson luketomlinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment, not a show stopper

Comment thread packages/glob/src/internal-hash-files.ts Outdated
core.debug(`Found ${count} files to hash.`)
return result.digest('hex')
} else {
core.error(`No matches found for glob`)

@luketomlinson luketomlinson Jun 7, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this feels more like a warning than an error

@thboop
thboop merged commit c5e1af5 into main Jun 7, 2021
@thboop
thboop deleted the thboop/HashFiles branch June 7, 2021 18:26
@syphar syphar mentioned this pull request Jun 8, 2021
Open
@Be-ing

Be-ing commented Aug 6, 2021

Copy link
Copy Markdown

Hi, I am trying to use this in an action. Could you please publish a new version of this module to NPM?

This was referenced Aug 6, 2021
Closed
Closed
@urica12

urica12 commented Oct 17, 2022

Copy link
Copy Markdown

Looks good! Thanks r

urica12
urica12 reviewed Oct 17, 2022
View reviewed changes

@urica12 urica12 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you