Prevent accidental file matching when glob contains trailing slash - #805
Merged
Conversation
ericsciple
reviewed
May 11, 2021
ericsciple
reviewed
May 11, 2021
ericsciple
reviewed
May 11, 2021
ericsciple
reviewed
May 11, 2021
ericsciple
reviewed
May 11, 2021
luketomlinson
marked this pull request as ready for review
May 11, 2021 21:11
luketomlinson
changed the title
ericsciple
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #628
Handles an odd case with
Minimatchthat we worked around before that inadvertently would match files when a trailing slash was added.