Skip to content

fix: reject non-semver candidate versions in isVersionSatisfies - #1009

Merged
v-HarithaVattikuti merged 2 commits into
actions:mainfrom
sproctor:main
Jun 18, 2026
Merged

fix: reject non-semver candidate versions in isVersionSatisfies#1009
v-HarithaVattikuti merged 2 commits into
actions:mainfrom
sproctor:main

Conversation

@sproctor

@sproctor sproctor commented May 26, 2026

Copy link
Copy Markdown
Contributor

Distributions like JetBrains Runtime publish 4-segment versions such as '17.0.8.1+1080.1' that the semver package rejects. Both compareBuild and satisfies throw on these, which surfaced to users as "Error: Invalid Version: 17.0.8.1+1080.1" and aborted the whole install when any available version was non-semver. Guard with an early semver.valid check so unparseable versions are treated as a non-match.

Description:
rejects invalid semver java versions rather than throwing an error. Allow valid java versions in a list with invalid versions to be used (specifically the JBR version mentioned above)

Related issue:
#1008

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@sproctor @claude
fix: reject non-semver candidate versions in isVersionSatisfies
ebc5abf 
Distributions like JetBrains Runtime publish 4-segment versions such as
'17.0.8.1+1080.1' that the semver package rejects. Both compareBuild and
satisfies throw on these, which surfaced to users as "Error: Invalid
Version: 17.0.8.1+1080.1" and aborted the whole install when any
available version was non-semver. Guard with an early semver.valid check
so unparseable versions are treated as a non-match.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@sproctor
sproctor requested a review from a team as a code owner May 26, 2026 23:43