fix: normalize internal plugin names - #4976
Merged
Merged
Conversation
antfu
previously approved these changes
Sep 18, 2021
Member
Author
|
@benmccann would you check this one just in case SvelteKit is removing or swapping a plugin by name? |
Shinigami92
previously approved these changes
Sep 18, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92
approved these changes
Sep 18, 2021
Shinigami92
left a comment
Shinigami92
left a comment
Member
There was a problem hiding this comment.
@antfu's review should still count 😅
Feel free to merge
Collaborator
|
This is fine from my end. Thanks for checking |
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Sep 22, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that all internal and official plugins names follow the
'vite:{name}'format.Plugin React and Vue were already using this format, but legacy and vue-jsx were not. There were several internal plugins that weren't following either.
Since we are now recommending the use of @antfu's https://github.com/antfu/vite-plugin-inspect, people will start to see and maybe rely on these names. This is a breaking change but I think it can safely be applied as part of the 2.6 beta
What is the purpose of this pull request?