Skip to content

fix: allow parsing of github expressions containing non-breaking-space characters, and allow dataflow analysis to fail - #1340

Merged
nicallen merged 2 commits into
mainfrom
nicallen/fix-dataflow-analysis-crashes
Mar 30, 2026
Merged

fix: allow parsing of github expressions containing non-breaking-space characters, and allow dataflow analysis to fail#1340
nicallen merged 2 commits into
mainfrom
nicallen/fix-dataflow-analysis-crashes

Conversation

@nicallen

@nicallen nicallen commented Mar 30, 2026 •
edited by behnazh-w
Loading

Copy link
Copy Markdown
Member

…to analyse a workflow without crashing Macaron entirely.

Summary

Fixes a crash caused by github expression parser not handling non-breaking-space characters (encountered when analysing https://github.com/openjdk/lanai and https://github.com/openjdk/jdk17u-ri).
Also allows Macaron to continue even if dataflow analysis fails (in which case only analysis of the offending workflow is skipped), which is useful to mitigate the impact of analysis bugs, as well as gracefully handle cases where a workflow is genuinely malformed (e.g. in one of the workflows of pkg:pypi/jupyter-client@8.7.0).
Also improves error reporting when the dataflow analysis fails, to report the failing workflow file.

Description of changes

Related issues

Checklist

  • I have reviewed the contribution guide.
  • My PR title and commits follow the Conventional Commits convention.
  • My commits include the "Signed-off-by" line.
  • I have signed my commits following the instructions provided by GitHub. Note that we run GitHub's commit verification tool to check the commit signatures. A green verified label should appear next to all of your commits on GitHub.
  • I have updated the relevant documentation, if applicable.
  • I have tested my changes and verified they work as expected.