Skip to content

fix: add identifier validation to inc() - #754

Merged
wraithgar merged 2 commits into
npm:mainfrom
mbtools:inc_validate_preid
Jan 28, 2025
Merged

fix: add identifier validation to inc()#754
wraithgar merged 2 commits into
npm:mainfrom
mbtools:inc_validate_preid

Conversation

@mbtools

@mbtools mbtools commented Jan 21, 2025

Copy link
Copy Markdown
Contributor
  • Adds a check of the identifier parameter for inc() when trying to increase pre-releases. This prevents the creation of an invalid semver.
  • Removes side-effects of inc() when it is throwing (it was changing the version)

Closes #349

@mbtools
mbtools requested a review from a team as a code owner January 21, 2025 19:38
Comment thread classes/semver.js