Skip to content

fix: better handling of whitespace (backport to v5) - #585

Merged
lukekarrys merged 1 commit into
npm:release/v5from
joaomoreno:joao/backport-564-to-v5
Jul 10, 2023
Merged

fix: better handling of whitespace (backport to v5)#585
lukekarrys merged 1 commit into
npm:release/v5from
joaomoreno:joao/backport-564-to-v5

Conversation

@joaomoreno

@joaomoreno joaomoreno commented Jul 7, 2023

Copy link
Copy Markdown

This backports the security fix #564 to v5.

@joaomoreno
joaomoreno requested a review from a team as a code owner July 7, 2023 13:45
@joaomoreno
joaomoreno force-pushed the joao/backport-564-to-v5 branch from 0572517 to 57bfd39 Compare July 7, 2023 13:47
@joaomoreno joaomoreno mentioned this pull request Jul 7, 2023
Merged
@wraithgar

wraithgar commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

#580 should be fixed before we go backporting anything so we don't bring new bugs along.

@wraithgar

wraithgar commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

#587 Also needs to be fixed

@lukekarrys
lukekarrys force-pushed the release/v5 branch 2 times, most recently from b67c2f8 to deb5ad5 Compare July 7, 2023 17:50
@lukekarrys

lukekarrys commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

the latest template-oss changes have been applied to release/v5. @joaomoreno can you rebase your branch so it only includes the semver.js and test/ changes?

@lukekarrys

lukekarrys commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

The full set of changes that should be backported are:

@lukekarrys @joaomoreno
fix: better handling of whitespace
d4530b8 
This is a backport of the following commits squashed to land on
`release/v5`:

- 717534e
- abdd93d
- cc6fde2
- 99d8287

Ref: npm#564

Co-authored-by: joaomoreno <mail@joaomoreno.com>
@lukekarrys
lukekarrys force-pushed the joao/backport-564-to-v5 branch from 74351cf to d4530b8 Compare July 7, 2023 22:37
@lukekarrys

lukekarrys commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

@joaomoreno i was able to push to your branch with the relevant commits. waiting on CI to see if tests pass in older versions of node

@lukekarrys lukekarrys changed the title Backport to v5: fix: better handling of whitespace fix: better handling of whitespace (backport to v5) Jul 7, 2023
@lukekarrys lukekarrys mentioned this pull request Jul 7, 2023
Closed
1 task
@joaomoreno

joaomoreno commented Jul 8, 2023

Copy link
Copy Markdown
Author

Sounds good, thanks @lukekarrys!

@lukekarrys
lukekarrys merged commit 2f8fd41 into npm:release/v5 Jul 10, 2023
@github-actions github-actions Bot mentioned this pull request Jul 10, 2023
Merged
@G-Rath

G-Rath commented Jul 10, 2023

Copy link
Copy Markdown

I've opened github/advisory-database#2483 updating the advisory for v5

@G-Rath

G-Rath commented Jul 10, 2023

Copy link
Copy Markdown

and I've opened github/advisory-database#2484 updating the advisory again for v6 and v5.

@lukekarrys

lukekarrys commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @G-Rath!

@joaomoreno

joaomoreno commented Jul 11, 2023

Copy link
Copy Markdown
Author

Thanks all!

@joaomoreno
joaomoreno deleted the joao/backport-564-to-v5 branch July 11, 2023 09:11
@aadhar-agarwal aadhar-agarwal mentioned this pull request Aug 17, 2023
Open
@github-actions github-actions Bot mentioned this pull request Dec 12, 2023
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Jan 31, 2024
Closed
@ehoogeveen-medweb ehoogeveen-medweb mentioned this pull request Feb 27, 2024
Closed
This was referenced May 19, 2024
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
Open
@ali8889 ali8889 mentioned this pull request Oct 30, 2024
Open
This was referenced Nov 6, 2024
Open
Open
This was referenced Jan 28, 2025
Open
Open
Open
Open
Open
This was referenced Feb 10, 2025
Open
Open
Open
Open
@pratheeshrussell-qb pratheeshrussell-qb mentioned this pull request Feb 20, 2025
Closed
@pratheeshrussell-qb pratheeshrussell-qb mentioned this pull request Apr 7, 2025
Closed
@github-actions github-actions Bot mentioned this pull request Apr 7, 2025
Closed
This was referenced Apr 25, 2025
Open
Open
@Susenthiran28 Susenthiran28 mentioned this pull request Apr 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wraithgar wraithgar wraithgar approved these changes
Reviewers whose approvals may not affect merge requirements